Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove can select many property from selection trees #1748

Merged
merged 2 commits into from
May 20, 2022

Conversation

mattseddon
Copy link
Member

@mattseddon mattseddon commented May 20, 2022

This PR turns off the unused/broken canSelectMany functionality in our selection view trees.

We can selectively turn it back on as/if we start to use it.

@mattseddon mattseddon self-assigned this May 20, 2022
@mattseddon mattseddon marked this pull request as ready for review May 20, 2022 05:26
@mattseddon mattseddon enabled auto-merge (squash) May 20, 2022 18:53
@codeclimate
Copy link

codeclimate bot commented May 20, 2022

Code Climate has analyzed commit c27520e and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (85% is the threshold).

This pull request will bring the total coverage in the repository to 96.7% (0.0% change).

View more on Code Climate.

@mattseddon mattseddon merged commit 38fb548 into main May 20, 2022
@mattseddon mattseddon deleted the turn-off-can-select-many branch May 20, 2022 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants